sqlparser: make index names optional#4166
Merged
sougou merged 2 commits intovitessio:masterfrom Sep 2, 2018
dt:name-opt
Merged
sqlparser: make index names optional#4166sougou merged 2 commits intovitessio:masterfrom dt:name-opt
sougou merged 2 commits intovitessio:masterfrom
dt:name-opt
Conversation
sougou
reviewed
Sep 1, 2018
go/vt/sqlparser/sql.y
Outdated
| { | ||
| $$ = "" | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Change is good.
Some nits:
- Existing code always lists the empty rule first. No particular reason, but it's better to follow existing convention.
- We generally don't mention
empty. But there's no harm. However, let's use//instead. - Also, lower level rules are listed below higher level ones, which means this should be moved after
index_or_key.
Contributor
Author
There was a problem hiding this comment.
Thanks! reordered, just removed the comment to stick with convention, and moved it below index_of_key.
Contributor
|
Need conflicts resolved. |
In some cases (versions?) mysqldump appears to emit default expressions with the parens in the CURRENT_TIMESTAMP call. This normalizes to no parens either way in the AST. Signed-off-by: David Taylor <tinystatemachine@gmail.com>
MySQL accepts index definitions without explicit names, e.g. 'UNIQUE KEY (a, b)'. Signed-off-by: David Taylor <tinystatemachine@gmail.com>
Contributor
Author
sougou
approved these changes
Sep 2, 2018
Contributor
|
I'm surprised (and worried) that the previous merge didn't cause a conflict with sql.go on this PR. |
Contributor
Author
|
I rebased it on top of #4168 while I was amending it (since that one was already approved) to avoid the conflict at merge — so this briefly briefly two commit PR until that one merged, at which point it went back to being just the one, but still applying cleanly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MySQL accepts index definitions without explicit names, e.g. 'UNIQUE KEY (a, b)'.
Signed-off-by: David Taylor tinystatemachine@gmail.com